Normalize Windows paths to Unix style before comparing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting an issue in which the whole Vue file was being taken as the content. The call to getSourceFile was being done two times: One with fileName which worked fine: "c:/Users/pablo/Documents/myApp/src/components/BankAccount.vue" And then a second call with the paths as follow which failed to correctly encode and thus failing the conditional: "c:\Users\pablo\Documents\myApp\src\components\BankAccount.vue" The toUnixPath changes all backward slashes to forward slashes before the encode step. As far as I have tested this replaces "fixSlashes" and my tests show that everything is working fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting an issue in which the whole Vue file was being taken as the content.
The call to getSourceFile was being done two times:
One with fileName which worked fine:
"c:/Users/pablo/Documents/myApp/src/components/BankAccount.vue"
And then a second call with the paths as follow which failed to correctly encode and thus failing the conditional:
"c:\Users\pablo\Documents\myApp\src\components\BankAccount.vue"
The toUnixPath changes all backward slashes to forward slashes before the encode step.
As far as I have tested this replaces "fixSlashes" and my tests show that everything is working fine.